GH-587: shnex:nodesWhere node expression #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolgerKnublauch
requested review from
afs,
recalcitrantsupplant,
robert-david and
simonstey
HolgerKnublauch
changed the title
Contributor
Author
|
May I get some feedback on this PR please? |
robert-david
requested changes
Nov 4, 2025
Contributor
See comments on the issue about naming. "nodesWhere" does not lead to a natural syntax in the rule language. "match", as originally proposed, does. |
TallTed
reviewed
Nov 4, 2025
shacl12-vocabularies/shnex.ttl
Outdated
| . | ||
|
|
||
|
|
||
| # Nodes Where Expressions ----------------------------------------------------- |
recalcitrantsupplant
approved these changes
Nov 10, 2025
Contributor
recalcitrantsupplant
left a comment
recalcitrantsupplant
left a comment
There was a problem hiding this comment.
looks good to me.
robert-david
requested changes
Nov 11, 2025
shacl12-node-expr/index.html
Outdated
| </aside> | ||
| <p> | ||
| The interpretation of <code>shnex:nodesMatching</code> is similar to <code>sh:targetWhere</code>. | ||
| The main differences are that <code>sh:targetMatching</code> is part of SHACL Core and that |
Contributor
There was a problem hiding this comment.
Should be sh:targetWhere instead of sh:targetMatching.
Changed sh:targetMatching to sh:targetWhere.
robert-david
approved these changes
Nov 11, 2025
Contributor
robert-david
left a comment
robert-david
left a comment
There was a problem hiding this comment.
Changed sh:targetMatching to sh:targetWhere.
afs
pushed a commit
that referenced
this pull request
Nov 17, 2025
* #587: Added shnex:where * Formatting (including unrelated examples) * Renamed from shnex:where to shnex:nodesWhere * Applied PR feedback * Renamed nodesWhere to nodesMatching * Update index.html Changed sh:targetMatching to sh:targetWhere. --------- Co-authored-by: Robert David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #587
The PR is large because it includes some fixes to the layout of various examples (tabs vs spaces, aligned use of blocks).